Issue 983923002: Revert of Add [TypeChecking=Interface] to Range interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 983923002: Revert of Add [TypeChecking=Interface] to Range interface (Closed)

Created:
5 years, 9 months ago by Dirk Pranke

Modified:
5 years, 9 months ago

Reviewers:
Jens Widell, philipj_slow

CC:
blink-reviews, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Add [TypeChecking=Interface] to Range interface (patchset #3 id:40001 of https://codereview.chromium.org/974823002/) Reason for revert: This is causing two Clipboard browser_tests to crash on multiple bots. I confirmed that reverting this change caused the tests to go back to passing. See, e.g.: https://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/5748 Original issue's description: > Add [TypeChecking=Interface] to Range interface > > All functions already threw exceptions for invalid argument values, but > DOMException exceptions instead of TypeError exceptions. > > Throwing TypeError exceptions matches Firefox's behavior. > > BUG=462561 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191363 TBR=philipj@opera.com,jl@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191392

Created: 5 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -63 lines)
D	LayoutTests/fast/dom/Range/invalid-arguments.html	View	1 chunk	+0 lines, -33 lines	0 comments
D	LayoutTests/fast/dom/Range/invalid-arguments-expected.txt	View	1 chunk	+0 lines, -20 lines	0 comments
M	LayoutTests/fast/dom/Range/range-compareNode.html	View	1 chunk	+1 line, -1 line	0 comments
M	LayoutTests/fast/dom/Range/range-intersectsNode-expected.txt	View	1 chunk	+1 line, -1 line	0 comments
M	LayoutTests/fast/text/first-letter-bad-line-boxes-crash-expected.txt	View	1 chunk	+1 line, -1 line	0 comments
M	Source/core/dom/Range.cpp	View	12 chunks	+53 lines, -4 lines	0 comments
M	Source/core/dom/Range.idl	View	3 chunks	+2 lines, -3 lines	0 comments

Total messages: 3 (0 generated)

Dirk Pranke

Created Revert of Add [TypeChecking=Interface] to Range interface

5 years, 9 months ago (2015-03-05 23:34:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983923002/1

5 years, 9 months ago (2015-03-05 23:35:56 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-05 23:36:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191392