Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 983903003: Re-work MaterialComponent (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
rafaelw, eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Re-work MaterialComponent Instead of MaterialComponent being a base class, components that want material behavior simply create a MaterialComponent during their render function. This approach gives the component more flexibility as to its structure and gives MaterialComponent more flexibility has to how the components it generates are related to the existing children. Also, I've improved some of the event delegation code. There's no reason to attach event handlers to the root component you emit during |render| because the framework already delegates events from your root component to you. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ea80070ae03f2b0ec666f0663ff84d1500a2b53d

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M sky/examples/stocks-fn/stockrow.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M sky/framework/components/button.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M sky/framework/components/button_base.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M sky/framework/components/checkbox.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M sky/framework/components/floating_action_button.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sky/framework/components/material.dart View 1 2 chunks +18 lines, -10 lines 0 comments Download
M sky/framework/components/menu_item.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/components/radio.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sky/framework/fn.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-06 03:09:18 UTC) #1
rafaelw
lgtm w/ question. I like this approach. https://codereview.chromium.org/983903003/diff/1/sky/framework/fn.dart File sky/framework/fn.dart (right): https://codereview.chromium.org/983903003/diff/1/sky/framework/fn.dart#newcode261 sky/framework/fn.dart:261: if (this ...
5 years, 9 months ago (2015-03-06 21:02:14 UTC) #3
abarth-chromium
https://codereview.chromium.org/983903003/diff/1/sky/framework/fn.dart File sky/framework/fn.dart (right): https://codereview.chromium.org/983903003/diff/1/sky/framework/fn.dart#newcode261 sky/framework/fn.dart:261: if (this == oldElement) On 2015/03/06 at 21:02:14, rafaelw ...
5 years, 9 months ago (2015-03-06 21:37:01 UTC) #4
abarth-chromium
5 years, 9 months ago (2015-03-11 17:17:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ea80070ae03f2b0ec666f0663ff84d1500a2b53d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698