Chromium Code Reviews
Help | Chromium Project | Sign in
(34)

Issue 9839012: Correct Mac browser icon rendering regressions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by Jeff Timanus
Modified:
5 years ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Correct the rendering of BrowserActionIcons on mac that was introduced by CL: http://src.chromium.org/viewvc/chrome?view=rev&revision=127196 The cocoa rendering code was assuming that the CanvasSkiaPaint object was initialized to 0, which is no longer true. This CL explicitly initializes the canvas before rendering the icon. BUG=118755 TEST=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 chunk +1 line, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 4 (0 generated)
Jeff Timanus
Can one of you please take a look. The fix for this issue turns out ...
5 years ago (2012-03-22 18:20:43 UTC) #1
Robert Sesek (OOO til Mar-29)
lgtm
5 years ago (2012-03-22 18:24:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/twiz@chromium.org/9839012/1
5 years ago (2012-03-22 18:30:31 UTC) #3
commit-bot: I haz the power
5 years ago (2012-03-22 19:43:48 UTC) #4
Change committed as 128271
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62