Chromium Code Reviews
Help | Chromium Project | Sign in

Issue 9839012: Correct Mac browser icon rendering regressions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
3 years, 8 months ago by Jeff Timanus
3 years, 8 months ago
chromium-reviews, Aaron Boodman,


Correct the rendering of BrowserActionIcons on mac that was introduced by CL: The cocoa rendering code was assuming that the CanvasSkiaPaint object was initialized to 0, which is no longer true. This CL explicitly initializes the canvas before rendering the icon. BUG=118755 TEST=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/extensions/ View 1 chunk +1 line, -0 lines 0 comments Download
Project "None" does not have a commit queue.


Total messages: 4 (0 generated)
Jeff Timanus
Can one of you please take a look. The fix for this issue turns out ...
3 years, 8 months ago (2012-03-22 18:20:43 UTC) #1
Robert Sesek
3 years, 8 months ago (2012-03-22 18:24:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at
3 years, 8 months ago (2012-03-22 18:30:31 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2012-03-22 19:43:48 UTC) #4
Change committed as 128271
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 6605a8d