chrome/browser/ui/views/tabs/tab.cc - Issue 983853002: Hide close buttons of inactive stacked tabs by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab.cc

Issue 983853002: Hide close buttons of inactive stacked tabs by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: histograms.xml changed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tabs/tab.cc

diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc

index 4121cc87a3ed564ffa8681f82d2ec1f163ab7876..bd937d3e60caea9cd3a2e8a29be2f25daf2e7e17 100644

--- a/chrome/browser/ui/views/tabs/tab.cc

+++ b/chrome/browser/ui/views/tabs/tab.cc

@@ -1461,7 +1461,7 @@ bool Tab::ShouldShowMediaIndicator() const {

}

bool Tab::ShouldShowCloseBox() const {

- if (!IsActive() && controller_->ShouldHideCloseButtonForInactiveTab(this))

+ if (!IsActive() && controller_->ShouldHideCloseButtonForInactiveTabs())

return false;

return chrome::ShouldTabShowCloseButton(

« no previous file with comments | « chrome/browser/ui/views/tabs/tab.h ('k') | chrome/browser/ui/views/tabs/tab_controller.h » ('j') | no next file with comments »