Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 983853002: Hide close buttons of inactive stacked tabs by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 257 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
258 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST, 258 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_FAST,
259 switches::kTabCaptureDownscaleQuality, "fast" }, 259 switches::kTabCaptureDownscaleQuality, "fast" },
260 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD, 260 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_GOOD,
261 switches::kTabCaptureDownscaleQuality, "good" }, 261 switches::kTabCaptureDownscaleQuality, "good" },
262 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST, 262 { IDS_FLAGS_TAB_CAPTURE_SCALE_QUALITY_BEST,
263 switches::kTabCaptureDownscaleQuality, "best" }, 263 switches::kTabCaptureDownscaleQuality, "best" },
264 }; 264 };
265 #endif 265 #endif
266 266
267 #if defined(TOOLKIT_VIEWS)
268 const Experiment::Choice kTabCloseButtonsHiddenWithTouchChoices[] = {
269 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
270 { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_ALWAYS,
271 switches::kTabCloseButtonsHiddenWithTouch, "always" },
272 { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_NARROW,
273 switches::kTabCloseButtonsHiddenWithTouch, "narrow" },
274 { IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_STACKED,
275 switches::kTabCloseButtonsHiddenWithTouch, "stacked" },
276 };
277 #endif
278
279 #if defined(OS_ANDROID) 267 #if defined(OS_ANDROID)
280 const Experiment::Choice kZeroSuggestExperimentsChoices[] = { 268 const Experiment::Choice kZeroSuggestExperimentsChoices[] = {
281 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 269 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
282 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED, 270 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED,
283 switches::kEnableZeroSuggestMostVisited, ""}, 271 switches::kEnableZeroSuggestMostVisited, ""},
284 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED_WITHOUT_SERP, 272 { IDS_FLAGS_ZERO_SUGGEST_MOST_VISITED_WITHOUT_SERP,
285 switches::kEnableZeroSuggestMostVisitedWithoutSerp, ""}, 273 switches::kEnableZeroSuggestMostVisitedWithoutSerp, ""},
286 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 274 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
287 switches::kDisableZeroSuggest, ""} 275 switches::kDisableZeroSuggest, ""}
288 }; 276 };
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
1374 { 1362 {
1375 "tab-capture-downscale-quality", 1363 "tab-capture-downscale-quality",
1376 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_NAME, 1364 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_NAME,
1377 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_DESCRIPTION, 1365 IDS_FLAGS_TAB_CAPTURE_DOWNSCALE_QUALITY_DESCRIPTION,
1378 kOsAll, 1366 kOsAll,
1379 MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices) 1367 MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices)
1380 }, 1368 },
1381 #endif 1369 #endif
1382 #if defined(TOOLKIT_VIEWS) 1370 #if defined(TOOLKIT_VIEWS)
1383 { 1371 {
1384 "tab-close-buttons-hidden-with-touch", 1372 "disable-hide-inactive-stacked-tab-close-buttons",
1385 IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_NAME, 1373 IDS_FLAGS_DISABLE_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME,
1386 IDS_FLAGS_TAB_CLOSE_BUTTONS_HIDDEN_WITH_TOUCH_DESCRIPTION, 1374 IDS_FLAGS_DISABLE_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION,
1387 kOsCrOS | kOsWin | kOsLinux, 1375 kOsCrOS | kOsWin | kOsLinux,
1388 MULTI_VALUE_TYPE(kTabCloseButtonsHiddenWithTouchChoices) 1376 SINGLE_VALUE_TYPE(switches::kDisableHideInactiveStackedTabCloseButtons)
1389 }, 1377 },
1390 #endif 1378 #endif
1391 { 1379 {
1392 "enable-webgl-draft-extensions", 1380 "enable-webgl-draft-extensions",
1393 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_NAME, 1381 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_NAME,
1394 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION, 1382 IDS_FLAGS_ENABLE_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION,
1395 kOsAll, 1383 kOsAll,
1396 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions) 1384 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions)
1397 }, 1385 },
1398 { 1386 {
(...skipping 1389 matching lines...) Expand 10 before | Expand all | Expand 10 after
2788 } 2776 }
2789 2777
2790 const Experiment* GetExperiments(size_t* count) { 2778 const Experiment* GetExperiments(size_t* count) {
2791 *count = num_experiments; 2779 *count = num_experiments;
2792 return experiments; 2780 return experiments;
2793 } 2781 }
2794 2782
2795 } // namespace testing 2783 } // namespace testing
2796 2784
2797 } // namespace about_flags 2785 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698