|
|
Created:
5 years, 9 months ago by nodir Modified:
5 years, 9 months ago CC:
chromium-reviews, cmp-cc_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
tools Visibility:
Public. |
DescriptionAdded nodir to OWNERS
R=sheyang@chromium.org, vadimsh@chromium.org
BUG=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294368
Patch Set 1 #Patch Set 2 : -cmp #Messages
Total messages: 14 (6 generated)
lgtm, but neither me nor Vadim is in the OWNERS file.
The CQ bit was checked by nodir@chromium.org
nodir@chromium.org changed reviewers: + hinoka@chromium.org, pgervais@chromium.org
+pgervais, +hinoka
On 2015/03/06 at 00:23:11, nodir wrote: > +pgervais, +hinoka You actually want to be an owner of depot_tools? :/ lgtm. glhf...
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sheyang@chromium.org Link to the patchset: https://codereview.chromium.org/983843003/#ps20001 (title: "-cmp")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983843003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 983843003-20001 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** tests/gclient_smoketest.py (56.80s) failed Ffatal: reference is not a tree: 12e1d71eb2fea3b450228defced62157ee396f56 EE.............................................. ====================================================================== ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest) Like testBlinkDEPSChangeUsingGclient, but move the main project using ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit cwd=self.checkout_path) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 484, in check_call check_call_out(args, **kwargs) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 478, in check_call_out returncode, args, kwargs.get('cwd'), out[0], out[1]) CalledProcessError: Command git checkout -q 12e1d71eb2fea3b450228defced62157ee396f56 returned non-zero exit status 128 in /tmp/trialirjklY/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src ====================================================================== ERROR: testBlinkLocalBranchesArePreserved (__main__.BlinkDEPSTransitionSmokeTest) Checks that the state of local git branches are effectively preserved ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/gclient_smoketest.py", line 1656, in testBlinkLocalBranchesArePreserved self.CheckStatusPreMergePoint() File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint self.blink), self.blink_git_url) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line 121, in Capture cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 515, in check_output return check_call_out(args, stdout=PIPE, **kwargs)[0] File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 475, in check_call_out out, returncode = communicate(args, **kwargs) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 449, in communicate proc = Popen(args, **kwargs) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 253, in __init__ % (str(e), kwargs.get('cwd'), args[0])) OSError: Execution failed with error: [Errno 2] No such file or directory: '/tmp/trialirjklY/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'. Check that /tmp/trialirjklY/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit or git exist and have execution permission. ====================================================================== FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest) Checks that {src,blink} repos are consistent when syncing going back and ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/gclient_smoketest.py", line 1601, in testBlinkDEPSChangeUsingGclient self.assertEqual(res[2], 0, 'DEPS change sync failed.') AssertionError: DEPS change sync failed. ---------------------------------------------------------------------- Ran 49 tests in 55.595s FAILED (failures=1, errors=2) Presubmit checks took 117.9s to calculate.
The CQ bit was checked by nodir@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983843003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=294368 |