Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983833004: Autofill OSX: Rename initWithWebContents -> initWithBridge. (Closed)

Created:
5 years, 9 months ago by bondd
Modified:
5 years, 9 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@cup_03_add_contents_06
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill OSX: Rename initWithWebContents -> initWithBridge. Rename initWithWebContents -> initWithBridge and remove |webContents_| because it is never used. BUG=448572 Committed: https://crrev.com/1203a7ecf74d8fc0ae9c64e688cf6034f86b2353 Cr-Commit-Position: refs/heads/master@{#319675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bondd
5 years, 9 months ago (2015-03-05 23:51:48 UTC) #3
groby-ooo-7-16
lgtm
5 years, 9 months ago (2015-03-06 19:35:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983833004/1
5 years, 9 months ago (2015-03-09 17:12:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 17:46:54 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:47:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1203a7ecf74d8fc0ae9c64e688cf6034f86b2353
Cr-Commit-Position: refs/heads/master@{#319675}

Powered by Google App Engine
This is Rietveld 408576698