Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issue 98383004: Remove TreatNullAs=NullString for HTMLInputElement (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLInputElement http://whatwg.org/html#htmlinputelement http://whatwg.org/html#HTMLInputElement-partial The value attribute has [TreatNullAs=EmptyString] in the spec, so leave it with [TreatNullAs=NullString] even though that doesn't exactly match the spec, to be fixed in a later commit. The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: Firefox reflects autocomplete as the empty string, and doesn't support dirName. IE throws an exception for align/type, doesn't support dirName, and doesn't reflect formAction as a URL. Opera doesn't reflect formAction as a URL, and reflects min/max as the empty string. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163033

Patch Set 1 #

Patch Set 2 : update tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -81 lines) Patch
M LayoutTests/fast/dom/domstring-attribute-reflection.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 2 1 chunk +30 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 2 1 chunk +19 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/date/ValidityState-rangeOverflow-date-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/input-inputmode.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-inputmode-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-minmax.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/input-minmax-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/input-pattern.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-pattern-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/month/ValidityState-rangeOverflow-month-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/submit-form-attributes.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/submit-form-attributes-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/time/time-validity-rangeoverflow-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/time/time-validity-rangeunderflow-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/week/ValidityState-rangeOverflow-week-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.idl View 2 chunks +21 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
7 years ago (2013-12-02 15:21:04 UTC) #1
arv (Not doing code reviews)
LGTM This one looks slightly more scary. Lets sleep with our eyes open tonight.
7 years ago (2013-12-02 15:29:20 UTC) #2
philipj_slow
On 2013/12/02 15:29:20, arv wrote: > LGTM > > This one looks slightly more scary. ...
7 years ago (2013-12-02 15:30:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/98383004/20001
7 years ago (2013-12-02 15:31:36 UTC) #4
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/domstring-attribute-reflection.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-02 16:45:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/98383004/40001
7 years ago (2013-12-02 19:59:33 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-02 21:56:41 UTC) #7
Message was sent while issue was closed.
Change committed as 163033

Powered by Google App Engine
This is Rietveld 408576698