chrome/browser/ui/webui/options/chromeos/internet_options_handler.h - Issue 983823002: Use GUID instead of servicePath in network settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

Issue 983823002: Use GUID instead of servicePath in network settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_enable_extension_apis

Patch Set: Feedback Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.h b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

index 49b52228e2fd0cd83bcea2e07624f3088a033075..2784880cda1ce61f425a722aa5c026be3eab7ffe 100644

--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

@@ -115,7 +115,7 @@ class InternetOptionsHandler

void FillNetworkInfo(base::DictionaryValue* dictionary);

// Keep track of the service path for the network shown in the Details view.

- std::string details_path_;

+ std::string details_guid_;

pneubeck (no reviews) 2015/03/13 09:54:20 I guess you tested something here. Not used.

stevenjb 2015/03/13 17:01:14 Oops, thanks. I thought I could do this easily usi

// Weak pointer factory so we can start connections at a later time

// without worrying that they will actually try to happen after the lifetime