ui/chromeos/network/network_state_notifier.h - Issue 983823002: Use GUID instead of servicePath in network settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/chromeos/network/network_state_notifier.h

Issue 983823002: Use GUID instead of servicePath in network settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_enable_extension_apis

Patch Set: Use guid instead of service_path for proxy prefs Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/chromeos/network/network_state_notifier.h

diff --git a/ui/chromeos/network/network_state_notifier.h b/ui/chromeos/network/network_state_notifier.h

index 092e5feba3a507222fa1f149c764f0397286aaa0..a86ec9109cc825a997ddc7482c7d155369b64c83 100644

--- a/ui/chromeos/network/network_state_notifier.h

+++ b/ui/chromeos/network/network_state_notifier.h

@@ -91,8 +91,8 @@ class UI_CHROMEOS_EXPORT NetworkStateNotifier

void UpdateCellularOutOfCredits(const chromeos::NetworkState* cellular);

void UpdateCellularActivating(const chromeos::NetworkState* cellular);

- // Invokes network_connect_->ShowNetworkSettings from a callback.

- void ShowNetworkSettings(const std::string& service_path);

+ // Invokes network_connect_->ShowNetworkSettingsForPath from a callback.

+ void ShowNetworkSettingsForPath(const std::string& service_path);

NetworkConnect* network_connect_; // unowned

std::string last_default_network_;

« no previous file with comments | « ui/chromeos/network/network_connect.cc ('k') | ui/chromeos/network/network_state_notifier.cc » ('j') | no next file with comments »