chrome/browser/ui/ash/network_connect_delegate_chromeos.cc - Issue 983823002: Use GUID instead of servicePath in network settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/network_connect_delegate_chromeos.cc

Issue 983823002: Use GUID instead of servicePath in network settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_enable_extension_apis

Patch Set: Use guid instead of service_path for proxy prefs Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/network_connect_delegate_chromeos.h ('k') | chrome/browser/ui/ash/system_tray_delegate_chromeos.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/network_connect_delegate_chromeos.cc

diff --git a/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc b/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc

index d1a051a2bb6c527add58eaac050dc1a97963bdc7..db74f16161989fab154495ad361d9a7aed32e40a 100644

--- a/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc

+++ b/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc

@@ -57,12 +57,12 @@ void NetworkConnectDelegateChromeOS::ShowNetworkConfigure(

NetworkConfigView::Show(network_id, GetNativeWindow());

}

-void NetworkConnectDelegateChromeOS::ShowNetworkSettings(

- const std::string& service_path) {

+void NetworkConnectDelegateChromeOS::ShowNetworkSettingsForGuid(

+ const std::string& network_id) {

if (!IsUIAvailable())

return;

- ash::Shell::GetInstance()->system_tray_delegate()->ShowNetworkSettings(

- service_path);

+ ash::Shell::GetInstance()->system_tray_delegate()->ShowNetworkSettingsForGuid(

+ network_id);

}

bool NetworkConnectDelegateChromeOS::ShowEnrollNetwork(

« no previous file with comments | « chrome/browser/ui/ash/network_connect_delegate_chromeos.h ('k') | chrome/browser/ui/ash/system_tray_delegate_chromeos.h » ('j') | no next file with comments »