Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

Issue 983793003: Replace extensions::ScopedPersistent with v8::UniquePersistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
diff --git a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
index b50d5ad43ec9d98fa11b16fe40b85faf41d6471c..bc7758c31fb38372c6043027e6c1ba8aade78631 100644
--- a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
+++ b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
@@ -177,9 +177,9 @@ v8::Local<v8::Object> MimeHandlerViewContainer::V8ScriptableObject(
if (scriptable_object_.IsEmpty()) {
v8::Local<v8::Object> object =
ScriptableObject::Create(isolate, weak_factory_.GetWeakPtr());
- scriptable_object_.reset(object);
+ scriptable_object_.Reset(isolate, object);
}
- return scriptable_object_.NewHandle(isolate);
+ return v8::Local<v8::Object>::New(isolate, scriptable_object_);
}
void MimeHandlerViewContainer::didReceiveData(blink::WebURLLoader* /* unused */,
@@ -200,8 +200,8 @@ void MimeHandlerViewContainer::didFinishLoading(
void MimeHandlerViewContainer::PostMessage(v8::Isolate* isolate,
v8::Handle<v8::Value> message) {
if (!guest_loaded_) {
- linked_ptr<ScopedPersistent<v8::Value>> scoped_persistent(
- new ScopedPersistent<v8::Value>(isolate, message));
+ linked_ptr<v8::UniquePersistent<v8::Value>> scoped_persistent(
+ new v8::UniquePersistent<v8::Value>(isolate, message));
pending_messages_.push_back(scoped_persistent);
return;
}
@@ -288,7 +288,7 @@ void MimeHandlerViewContainer::OnMimeHandlerViewGuestOnLoadCompleted(
v8::HandleScope handle_scope(isolate);
v8::Context::Scope context_scope(frame->mainWorldScriptContext());
for (const auto& pending_message : pending_messages_)
- PostMessage(isolate, pending_message->NewHandle(isolate));
+ PostMessage(isolate, v8::Local<v8::Value>::New(isolate, *pending_message));
pending_messages_.clear();
}

Powered by Google App Engine
This is Rietveld 408576698