Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.h

Issue 983793003: Replace extensions::ScopedPersistent with v8::UniquePersistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/extensions_guest_view_container.h
diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.h b/extensions/renderer/guest_view/extensions_guest_view_container.h
index df257f18171a99d9d9aab21d599c6c3135699608..cd03f63e68fdc8a6db63591099500dbe36e9c74b 100644
--- a/extensions/renderer/guest_view/extensions_guest_view_container.h
+++ b/extensions/renderer/guest_view/extensions_guest_view_container.h
@@ -11,7 +11,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/values.h"
#include "extensions/renderer/guest_view/guest_view_container.h"
-#include "extensions/renderer/scoped_persistent.h"
+#include "v8/include/v8.h"
namespace gfx {
class Size;
@@ -42,7 +42,7 @@ class ExtensionsGuestViewContainer : public GuestViewContainer {
private:
GuestViewContainer* container_;
- ScopedPersistent<v8::Function> callback_;
+ v8::UniquePersistent<v8::Function> callback_;
v8::Isolate* const isolate_;
};
@@ -110,10 +110,10 @@ class ExtensionsGuestViewContainer : public GuestViewContainer {
std::deque<linked_ptr<Request> > pending_requests_;
linked_ptr<Request> pending_response_;
- ScopedPersistent<v8::Function> destruction_callback_;
+ v8::UniquePersistent<v8::Function> destruction_callback_;
v8::Isolate* destruction_isolate_;
- ScopedPersistent<v8::Function> element_resize_callback_;
+ v8::UniquePersistent<v8::Function> element_resize_callback_;
v8::Isolate* element_resize_isolate_;
// Weak pointer factory used for calling the element resize callback.
« no previous file with comments | « extensions/renderer/app_window_custom_bindings.cc ('k') | extensions/renderer/guest_view/extensions_guest_view_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698