Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Unified Diff: extensions/renderer/activity_log_converter_strategy_unittest.cc

Issue 983793003: Replace extensions::ScopedPersistent with v8::UniquePersistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/extensions.gypi ('k') | extensions/renderer/app_window_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/activity_log_converter_strategy_unittest.cc
diff --git a/extensions/renderer/activity_log_converter_strategy_unittest.cc b/extensions/renderer/activity_log_converter_strategy_unittest.cc
index 137c544c24c2c0b61b59785582057a0c2cfe61a1..da1cc2ad4e8101cca1cbc1862a13d8d8386639ab 100644
--- a/extensions/renderer/activity_log_converter_strategy_unittest.cc
+++ b/extensions/renderer/activity_log_converter_strategy_unittest.cc
@@ -5,7 +5,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/values.h"
#include "extensions/renderer/activity_log_converter_strategy.h"
-#include "extensions/renderer/scoped_persistent.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "v8/include/v8.h"
@@ -16,11 +15,10 @@ namespace extensions {
class ActivityLogConverterStrategyTest : public testing::Test {
public:
ActivityLogConverterStrategyTest()
- : isolate_(v8::Isolate::GetCurrent())
- , handle_scope_(isolate_)
- , context_(v8::Context::New(isolate_))
- , context_scope_(context()) {
- }
+ : isolate_(v8::Isolate::GetCurrent()),
+ handle_scope_(isolate_),
+ context_(isolate_, v8::Context::New(isolate_)),
+ context_scope_(context()) {}
protected:
void SetUp() override {
@@ -87,12 +85,12 @@ class ActivityLogConverterStrategyTest : public testing::Test {
}
v8::Handle<v8::Context> context() const {
- return context_.NewHandle(isolate_);
+ return v8::Local<v8::Context>::New(isolate_, context_);
}
v8::Isolate* isolate_;
v8::HandleScope handle_scope_;
- ScopedPersistent<v8::Context> context_;
+ v8::UniquePersistent<v8::Context> context_;
v8::Context::Scope context_scope_;
scoped_ptr<V8ValueConverter> converter_;
scoped_ptr<ActivityLogConverterStrategy> strategy_;
« no previous file with comments | « extensions/extensions.gypi ('k') | extensions/renderer/app_window_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698