Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 983743003: Remove SkPorterDuff now that Android has been updated. (Closed)

Created:
5 years, 9 months ago by djsollen
Modified:
5 years, 9 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkPorterDuff now that Android has been updated. BUG=skia:3178 Committed: https://skia.googlesource.com/skia/+/961707f384501da742a410c185e7afa332273d2d

Patch Set 1 #

Patch Set 2 : update gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -182 lines) Patch
M gyp/effects.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D include/effects/SkPorterDuff.h View 1 chunk +0 lines, -87 lines 0 comments Download
D src/effects/SkPorterDuff.cpp View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
djsollen
5 years, 9 months ago (2015-03-05 17:54:34 UTC) #2
scroggo
Don't you need to update the gyp file?
5 years, 9 months ago (2015-03-05 19:24:28 UTC) #3
djsollen
gyp is updated. ptal.
5 years, 9 months ago (2015-03-05 20:10:43 UTC) #4
scroggo
lgtm
5 years, 9 months ago (2015-03-05 20:12:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983743003/20001
5 years, 9 months ago (2015-03-05 20:23:24 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 20:42:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/961707f384501da742a410c185e7afa332273d2d

Powered by Google App Engine
This is Rietveld 408576698