Issue 983733003: Add constants for material colors and shadows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 983733003: Add constants for material colors and shadows (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add constants for material colors and shadows This CL removes the hard-coded colors and shadows from the fn widgets and replaces them with compile-time constants. The color values are from the material spec: http://www.google.com/design/spec/style/color.html#color-color-palette R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b1ab58a6917147a92d61b20148e86a02b56f54fe

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+269 lines, -6 lines)			Patch
M	sky/examples/fn/widgets/drawer.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/examples/fn/widgets/drawerheader.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/fn/widgets/floating_action_button.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/fn/widgets/toolbar.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/examples/fn/widgets/widgets.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	sky/framework/theme/colors.dart	View	1 chunk	+250 lines, -0 lines	0 comments	Download
A	sky/framework/theme/shadows.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-05 17:58:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b1ab58a6917147a92d61b20148e86a02b56f54fe (presubmit successful).