Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: pkg/analyzer/lib/src/analyzer_impl.dart

Issue 983733002: No errors in third-party packages (issue 22170) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/analyzer_impl.dart
diff --git a/pkg/analyzer/lib/src/analyzer_impl.dart b/pkg/analyzer/lib/src/analyzer_impl.dart
index 222aad7f1a1378830e54f1b91ee62255a1a1f437..849356fd0335af373f9d7a6c35e8a91e7b3778c8 100644
--- a/pkg/analyzer/lib/src/analyzer_impl.dart
+++ b/pkg/analyzer/lib/src/analyzer_impl.dart
@@ -150,7 +150,7 @@ class AnalyzerImpl {
new DartUriResolver(sdk),
new FileUriResolver()
];
- // may be add package resolver
+ // maybe add package resolver
{
JavaFile packageDirectory;
if (options.packageRootPath != null) {
@@ -187,6 +187,8 @@ class AnalyzerImpl {
contextOptions.hint = !options.disableHints;
contextOptions.analyzeFunctionBodiesPredicate =
_analyzeFunctionBodiesPredicate;
+ contextOptions.generateImplicitErrors = options.showPackageWarnings;
+ contextOptions.generateSdkErrors = options.showSdkWarnings;
context.analysisOptions = contextOptions;
// Create and add a ChangeSet

Powered by Google App Engine
This is Rietveld 408576698