Issue 98373007: Move more helpers to seccomp-bpf-helpers.

Issue 98373007: Move more helpers to seccomp-bpf-helpers. (Closed)

Created:
7 years ago by jln (very slow on Chromium)

Modified:
7 years ago

Reviewers:
Jorge Lucangeli Obes

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move more helpers to seccomp-bpf-helpers. Extract more code from content/common/sandbox_seccomp_bpf_linux.cc and move it to sandbox/linux/seccomp-bpf-helpers/ BUG=325535 NOTRY=true R=jorgelo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238994

Patch Set 1 : More headers. #

Patch Set 2 : Define F_DUPFD_CLOEXEC for Android. #

Patch Set 3 : Define MAP_STACK #

Total comments: 4

Patch Set 4 : Address nits. #

Patch Set 5 : Rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+479 lines, -287 lines)			Patch
M	content/common/sandbox_seccomp_bpf_linux.cc	View	1 2	6 chunks	+2 lines, -284 lines	0 comments	Download
M	sandbox/linux/sandbox_linux.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h	View		1 chunk	+43 lines, -0 lines	0 comments	Download
A	sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc	View	1 2 3	1 chunk	+146 lines, -0 lines	0 comments	Download
A	sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h	View		1 chunk	+63 lines, -0 lines	0 comments	Download
A	sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc	View	1 2	1 chunk	+218 lines, -0 lines	0 comments	Download
M	sandbox/linux/seccomp-bpf-helpers/syscall_sets.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jln (very slow on Chromium)

(Please send to the CQ if you're happy with it)

7 years ago (2013-12-05 03:00:34 UTC) #2

Jorge Lucangeli Obes

https://codereview.chromium.org/98373007/diff/90001/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc File sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc (right): https://codereview.chromium.org/98373007/diff/90001/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc#newcode33 sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:33: // use it to perform a non blocking write. ...

7 years ago (2013-12-05 16:46:29 UTC) #3

jln (very slow on Chromium)

Thanks, PTAL! https://codereview.chromium.org/98373007/diff/90001/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc File sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc (right): https://codereview.chromium.org/98373007/diff/90001/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc#newcode33 sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:33: // use it to perform a non ...

7 years ago (2013-12-05 18:02:46 UTC) #4

jln (very slow on Chromium)

7 years ago (2013-12-05 18:20:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 manually as r238994 (presubmit successful).

Expand Messages | Collapse Messages