Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 98373003: Do proper cpu checking for NEON SkBoxBlur procs. (Closed)

Created:
7 years ago by Stephen White
Modified:
7 years ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
/usr/local/google/home/senorblanco/src/skia-android/../skia@master
Visibility:
Public.

Description

Do proper NEON checking for SkBoxBlur procs. TBR=mtklein BUG= Committed: https://code.google.com/p/skia/source/detail?r=12490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
A + src/opts/SkBlurImage_opts_neon.h View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkBlurImage_opts_neon.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/opts/opts_check_arm.cpp View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen White
Landing this TBR to fix the bots.
7 years ago (2013-12-04 19:52:41 UTC) #1
Stephen White
Committed patchset #1 manually as r12490 (presubmit successful).
7 years ago (2013-12-04 19:53:46 UTC) #2
mtklein
7 years ago (2013-12-04 20:42:58 UTC) #3
Message was sent while issue was closed.
On 2013/12/04 19:53:46, Stephen White wrote:
> Committed patchset #1 manually as r12490 (presubmit successful).

duh, lgtm.

Powered by Google App Engine
This is Rietveld 408576698