Issue 983713004: Delay testing lifecycle observers until known to be alive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 983713004: Delay testing lifecycle observers until known to be alive. (Closed)

Created:
5 years, 9 months ago by sof

Modified:
5 years, 9 months ago

Reviewers:
haraken, hiroshige

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Delay testing lifecycle observers until known to be alive. When iterating, ContextLifecycleNotifier must be able to cope with pointer references to ContextLifecycleObservers that may have been destructed while iterating&notifying others. Delay the observer type check until we've verified that the observer is alive. R=haraken BUG=464285 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191372

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	Source/core/dom/ContextLifecycleNotifier.cpp	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983713004/1

5 years, 9 months ago (2015-03-05 16:33:25 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-05 17:28:38 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191372

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages