Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix indentation. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index fbbff999d28d9b3b282bae4698a4965ac512123d..a0dc2a3719e2c5784b35f023eb80f18608a1ee2f 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -403,10 +403,17 @@ void RenderMessageFilter::OnMsgCreateWindow(
int* route_id,
int* surface_id,
int64* cloned_session_storage_namespace_id) {
- if (!content::GetContentClient()->browser()->CanCreateWindow(
- GURL(params.opener_url), GURL(params.opener_security_origin),
- params.window_container_type, resource_context_,
- render_process_id_)) {
+ bool no_javascript_access;
+ bool can_create_window =
+ content::GetContentClient()->browser()->CanCreateWindow(
+ GURL(params.opener_url),
+ GURL(params.opener_security_origin),
+ params.window_container_type,
+ resource_context_,
+ render_process_id_,
+ &no_javascript_access);
+
+ if (!can_create_window) {
*route_id = MSG_ROUTING_NONE;
*surface_id = 0;
return;
@@ -428,6 +435,7 @@ void RenderMessageFilter::OnMsgCreateWindow(
#endif
render_widget_helper_->CreateNewWindow(params,
+ no_javascript_access,
peer_handle(),
route_id,
surface_id);
« no previous file with comments | « content/browser/mock_content_browser_client.cc ('k') | content/browser/renderer_host/render_widget_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698