chrome/browser/ui/intents/web_intent_picker_controller.cc - Issue 9837054: Improve WebstoreInstaller error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.cc

Issue 9837054: Improve WebstoreInstaller error handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/intents/web_intent_picker_controller.cc

diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.cc b/chrome/browser/ui/intents/web_intent_picker_controller.cc

index f45a7e32ac27534c9ff8f034c82d35f7bfac074f..b0d3e04c75246d51c95b660919ecc6175e8660ea 100644

--- a/chrome/browser/ui/intents/web_intent_picker_controller.cc

+++ b/chrome/browser/ui/intents/web_intent_picker_controller.cc

@@ -276,12 +276,12 @@ void WebIntentPickerController::OnInlineDispositionWebContentsCreated(

void WebIntentPickerController::OnExtensionInstallRequested(

const std::string& id) {

- webstore_installer_ = new WebstoreInstaller(

+ scoped_refptr<WebstoreInstaller> installer = new WebstoreInstaller(

wrapper_->profile(), this, &wrapper_->web_contents()->GetController(), id,

WebstoreInstaller::FLAG_INLINE_INSTALL);

pending_async_count_++;

- webstore_installer_->Start();

+ installer->Start();

}

void WebIntentPickerController::OnCancelled() {