Issue 9837026: Histogram times surrounding render crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9837026: Histogram times surrounding render crashes (Closed)

Created:
8 years, 9 months ago by jar (doing other things)

Modified:
8 years, 9 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, MAD, jar (doing other things), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, Ilya Sherman, karen

Base URL:
svn://svn.chromium.org/chrome/branches/1025/src/

Visibility:
Public.

Histogram times surrounding render crashes Originally reviewed as CL patch set 10 of https://chromiumcodereview.appspot.com/9769011/ This version will land on the M18 branch only. Report exec time, kernal time, and user cpu time when we have a crash. Also report non-crashing durations for comparison. r=rvargas Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128335

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -54 lines)			Patch
M	chrome/browser/metrics/metrics_service.h	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.cc	View	1	2 chunks	+48 lines, -12 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.h	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1	5 chunks	+21 lines, -24 lines	0 comments	Download
M	content/public/browser/render_process_host.h	View	1	1 chunk	+34 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

jar (doing other things)

This is just the patch, applied to an M18 tree... and ready to land.

8 years, 9 months ago (2012-03-22 22:54:27 UTC) #1

LGTM