Issue 98363008: This is essentially just a similarity=50 version of https://codereview.chromium.org/95133002/ and i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98363008: This is essentially just a similarity=50 version of https://codereview.chromium.org/95133002/ and i… (Closed)

Created:
7 years ago by Finnur

Modified:
7 years ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, oshima+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This is essentially just a similarity=50 version of https://codereview.chromium.org/95133002/ (patchset 17) and is purely for patching into a local tree, not for checkin. BUG=

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : git cl try #

Patch Set 4 : #

Patch Set 5 : Mergefix #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1550 lines, -298 lines)			Patch
M	chrome/app/theme/theme_resources.grd	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/dev_mode_bubble_controller.h	View		1 chunk	+86 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/dev_mode_bubble_controller.cc	View	1 2	1 chunk	+149 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/dev_mode_bubble_controller_delegate.cc	View		1 chunk	+144 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_message_bubble.h	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_message_bubble_controller.h	View	1 2	1 chunk	+111 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_message_bubble_controller.cc	View	1 2	1 chunk	+151 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_message_bubble_controller_unittest.cc	View	1 2 3 4	1 chunk	+392 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/extensions/suspicious_extension_bubble.h	View		1 chunk	+0 lines, -28 lines	0 comments	Download
M	chrome/browser/extensions/suspicious_extension_bubble_controller.h	View	1 2 3 4	4 chunks	+28 lines, -36 lines	0 comments	Download
M	chrome/browser/extensions/suspicious_extension_bubble_controller.cc	View	1 2 3 4	5 chunks	+61 lines, -111 lines	0 comments	Download
M	chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	chrome/browser/ui/views/extensions/extension_message_bubble_view.h	View	1 2	4 chunks	+25 lines, -20 lines	0 comments	Download
A	chrome/browser/ui/views/extensions/extension_message_bubble_view.cc	View	1 2	1 chunk	+325 lines, -0 lines	0 comments	Download
D	chrome/browser/ui/views/extensions/suspicious_extension_bubble_view.h	View		1 chunk	+0 lines, -91 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar/browser_action_view.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar/browser_actions_container.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar/toolbar_view.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	extensions/common/feature_switch.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/common/feature_switch.cc	View	1 2 3	3 chunks	+7 lines, -0 lines	0 comments	Download
M	extensions/common/switches.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/common/switches.cc	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download