Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983623002: Made the entries of the various *_FUNCTION_LISTs disjoint. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Made the entries of the various *_FUNCTION_LISTs disjoint. This way, every function in those lists has one C++ implementation called Runtime_##name. The previous distinction was confusing. Committed: https://crrev.com/d271599f08f11c15c08cc20f8b3c9e566cd7a061 Cr-Commit-Position: refs/heads/master@{#27010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -86 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M src/runtime/runtime-array.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-date.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-function.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/runtime/runtime-proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-strings.cc View 5 chunks +6 lines, -24 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 9 months ago (2015-03-05 10:39:26 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-05 10:52:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983623002/1
5 years, 9 months ago (2015-03-05 11:15:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 11:26:38 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 11:26:51 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d271599f08f11c15c08cc20f8b3c9e566cd7a061
Cr-Commit-Position: refs/heads/master@{#27010}

Powered by Google App Engine
This is Rietveld 408576698