Use the installed/downloaded objdump instead of work-dir one.

Makefile.standalone

 # The following variables will likely need to be modified, depending on where
 # and how you built LLVM & Clang. They can be overridden in a command-line
 # invocation of make, like:
 #
 #   make LLVM_SRC_PATH=<path> LLVM_BIN_PATH=<path> \
 #        LIBCXX_INSTALL_PATH=<path> CLANG_PATH=<path> ...

[Jim Stichnoth, 2015/03/05 17:19:53]

Maybe add BINUTILS_BIN_PATH here for consistency?

[jvoung (off chromium), 2015/03/05 19:26:06]

Done.

 #
 
 # LLVM_SRC_PATH is the path to the root of the checked out source code. This
 # directory should contain the configure script, the include/ and lib/
 # directories of LLVM, Clang in tools/clang/, etc.
 # Alternatively, if you're building vs. a binary download of LLVM, then
 # LLVM_SRC_PATH can point to the main untarred directory.
 LLVM_SRC_PATH ?= ../llvm
 
 # LLVM_BIN_PATH is the directory where binaries are placed by the LLVM build
 # process. It should contain the tools like opt, llc and clang. The default

[Jim Stichnoth, 2015/03/05 17:19:53]

Can you update the comment to reflect the actual set of tools?  This includes
llvm-as, pnacl-freeze, and llvm-mc (via lit.cfg and run-pnacl-sz.py), and
llvm-config and clang-format (via this makefile).

Interestingly, all of those except clang-format appear to be available in
BINUTILS_BIN_PATH, so maybe the latter could be used in the normal case? 
(Except that the two versions of llvm-config seem to produce slightly different
output, so...)

[jvoung (off chromium), 2015/03/05 19:26:06]

My main fear of listing all the tools in the comment, is that it
can go stale without breaking tests/notice, but okay.
Yes, that bin path has almost everything. It would be nice if there's one bin
directory, but as you noticed there are problems with clang-format and
llvm-config. The llvm-config --ldflags says:


-L/usr/local/google/home/nacl3/native_client/toolchain/linux_x86/pnacl_newlib/lib

but that directory has pruned out the .a files since normal developers don't
really need them, so we can't use that directory. I guess one alternative is to
instead have an LLVM_LIBS_PATH to replace the `llvm-config --ldflags` output.

The clang-format issue is that toolchain_build prunes it. We could potentially
change that. I don't know if SDK users would start using that or not.

[Jim Stichnoth, 2015/03/05 19:34:18]

Good point.  If you want to future-proof the test, that's fine, otherwise we can
future-proof it next time we notice it's gone stale. :)

[jvoung (off chromium), 2015/03/05 20:11:03]

Hmm, next time =)

 # reflects a debug build with autotools (configure & make).
 LLVM_BIN_PATH ?= $(shell readlink -e \
         ../../out/llvm_x86_64_linux_work/Release+Asserts/bin)
 
 # LIBCXX_INSTALL_PATH is the directory where libc++ is located. It should
 # contain header files and corresponding libraries
 LIBCXX_INSTALL_PATH ?= $(shell readlink -e \
         ../../../toolchain/linux_x86/pnacl_newlib)
 
 # CLANG_PATH is the location of the clang compiler to use.
 CLANG_PATH ?= $(shell readlink -e \
         ../../../../third_party/llvm-build/Release+Asserts/bin)
 
 # The location of binutils tools (e.g., objdump).
 BINUTILS_BIN_PATH ?= $(shell readlink -e \

[Jim Stichnoth, 2015/03/05 17:19:53]

There's a pretty strong and fixed relationship between LIBCXX_INSTALL_PATH and
BINUTILS_BIN_PATH, right?  Could we drop one of them or combine into a new one?

[jvoung (off chromium), 2015/03/05 19:26:06]

Added a common base, for default initialization. I don't know how necessary the
overrides are, so I kept them separate for now.

I noticed a couple similar paths in other scripts, so I changed build-runtime to
use this root instead. Didn't change crosstests or szbuild (szbuild I assume
would be run without the makefile).

-        ../../out/binutils_pnacl_x86_64_linux_work/binutils)
+        ../../../toolchain/linux_x86/pnacl_newlib/bin)
 
 HOST_ARCH ?= x86_64
 ifeq ($(HOST_ARCH),x86_64)
   HOST_FLAGS = -m64 -stdlib=libc++
 else
   ifeq ($(HOST_ARCH),x86)
     HOST_FLAGS = -m32 -stdlib=libc++
   endif
 endif
 
@@ skipping 190 matching lines @@
 bloat: make_symlink
         nm -C -S -l pnacl-sz | \
         bloat/bloat.py --nm-output=/dev/stdin syms > build/pnacl-sz.bloat.json
         @echo See Subzero size breakdown in bloat/pnacl-sz.bloat.html
 
 clean:
         rm -rf pnacl-sz *.o $(OBJDIR) build/pnacl-sz.bloat.json
 
 clean-all: clean
         rm -rf build/