Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 98353006: Fix getPaddingStart/getPaddingEnd in ApiCompatibilityUtils.java (Closed)

Created:
7 years ago by Anuj
Modified:
7 years ago
Reviewers:
Yaron, Maria
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix getPaddingStart/getPaddingEnd in ApiCompatibilityUtils.java BUG=327833 R=yfriedman@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Anuj
PTAL.
7 years ago (2013-12-14 03:15:32 UTC) #1
Maria
lgtm Hilarious.
7 years ago (2013-12-14 17:32:52 UTC) #2
Anuj
I guess this is not worth waiting for another review. I will CQ it with ...
7 years ago (2013-12-14 20:54:34 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-14 20:54:51 UTC) #4
Yaron
lgtm
7 years ago (2013-12-16 17:57:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skanuj@chromium.org/98353006/1
7 years ago (2013-12-16 18:02:24 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204964
7 years ago (2013-12-16 19:13:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skanuj@chromium.org/98353006/1
7 years ago (2013-12-16 20:55:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skanuj@chromium.org/98353006/1
7 years ago (2013-12-16 23:59:04 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-17 00:07:17 UTC) #10
Message was sent while issue was closed.
Change committed as 241076

Powered by Google App Engine
This is Rietveld 408576698