Issue 98353004: support multi-level symlinks to SDK exes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98353004: support multi-level symlinks to SDK exes (Closed)

Created:
7 years ago by kevmoo-old

Modified:
7 years ago

Reviewers:
Bob Nystrom, ahe, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

support multi-level symlinks to SDK exes BUG= https://code.google.com/p/dart/issues/detail?id=15486 Closed per https://codereview.chromium.org/106863004/

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -72 lines)			Patch
M	sdk/bin/dart	View	1 chunk	+8 lines, -10 lines	0 comments	Download
M	sdk/bin/dart2js	View	1 chunk	+8 lines, -10 lines	1 comment	Download
M	sdk/bin/dartanalyzer	View	1 chunk	+8 lines, -10 lines	0 comments	Download
M	sdk/bin/dartanalyzer_developer	View	1 chunk	+8 lines, -10 lines	0 comments	Download
M	sdk/bin/dartdoc	View	1 chunk	+8 lines, -10 lines	0 comments	Download
M	sdk/bin/pub	View	1 chunk	+9 lines, -11 lines	0 comments	Download
M	sdk/bin/pub_developer	View	1 chunk	+9 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo-old

All I know about bash programming, I've stolen from Stack Overflow: http://stackoverflow.com/a/697552/39827 Validated on my ...

7 years ago (2013-12-06 04:25:07 UTC) #1

ahe

https://codereview.chromium.org/98353004/diff/1/sdk/bin/dart2js File sdk/bin/dart2js (left): https://codereview.chromium.org/98353004/diff/1/sdk/bin/dart2js#oldcode10 sdk/bin/dart2js:10: file="$(readlink "$file")" The problem is this line. On Mac, ...

7 years ago (2013-12-06 08:06:29 UTC) #2

ahe

I've created this alternative https://codereview.chromium.org/106863004/ And this time I have documented why I avoid dirname, ...

7 years ago (2013-12-06 08:52:13 UTC) #3

Closing per https://codereview.chromium.org/106863004/

Expand Messages | Collapse Messages