Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 9835045: Support IME properties in uber tray. (Closed)

Created:
8 years, 9 months ago by Jun Mukai
Modified:
8 years, 9 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Support IME properties in uber tray. BUG=118862, 119672 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128487

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : remove explicit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -12 lines) Patch
M ash/shell.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ash/system/ime/tray_ime.cc View 1 2 5 chunks +49 lines, -12 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
8 years, 9 months ago (2012-03-23 08:42:01 UTC) #1
Yusuke Sato
Thanks for working on this. Please add BUG=119672 as well. http://codereview.chromium.org/9835045/diff/1/ash/system/ime/tray_ime.cc File ash/system/ime/tray_ime.cc (right): http://codereview.chromium.org/9835045/diff/1/ash/system/ime/tray_ime.cc#newcode94 ...
8 years, 9 months ago (2012-03-23 08:54:22 UTC) #2
Jun Mukai
http://codereview.chromium.org/9835045/diff/1/ash/system/ime/tray_ime.cc File ash/system/ime/tray_ime.cc (right): http://codereview.chromium.org/9835045/diff/1/ash/system/ime/tray_ime.cc#newcode94 ash/system/ime/tray_ime.cc:94: if (status_ != user::LOGGED_IN_NONE) On 2012/03/23 08:54:22, Yusuke Sato ...
8 years, 9 months ago (2012-03-23 09:05:42 UTC) #3
Yusuke Sato
lgtm assuming that you'll file another bug for the lock screen. On 2012/03/23 09:05:42, Jun ...
8 years, 9 months ago (2012-03-23 09:51:58 UTC) #4
sadrul
Thanks for fixing! LGTM (I can take care of the lock-screen issue with 119503) http://codereview.chromium.org/9835045/diff/4001/ash/system/ime/tray_ime.cc ...
8 years, 9 months ago (2012-03-23 12:22:48 UTC) #5
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-23 14:57:34 UTC) #6
Jun Mukai
8 years, 9 months ago (2012-03-23 14:57:47 UTC) #7
Yusuke, there is already a bug (crbug.com/119503) and pkotwicz is working on it
(thanks for teaching this sadrul)

http://codereview.chromium.org/9835045/diff/4001/ash/system/ime/tray_ime.cc
File ash/system/ime/tray_ime.cc (right):

http://codereview.chromium.org/9835045/diff/4001/ash/system/ime/tray_ime.cc#n...
ash/system/ime/tray_ime.cc:68: explicit IMEDetailedView(SystemTrayItem* owner,
user::LoginStatus status)
On 2012/03/23 12:22:49, sadrul wrote:
> Remove explicit

Done.

Powered by Google App Engine
This is Rietveld 408576698