Issue 9835032: aura: Make RootWindow::DispatchKeyEvent drop unknown keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9835032: aura: Make RootWindow::DispatchKeyEvent drop unknown keys. (Closed)

Created:
8 years, 9 months ago by Daniel Erat

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, rniwa-cr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Make RootWindow::DispatchKeyEvent drop unknown keys. On Chrome OS, Aura receives XF86PowerOff KeyPress and KeyRelease events from X when the power button is pressed or released. These are converted to VKEY_UNKNOWN and were ending up as events with keyCode=0 and charCode=0 in the renderer. This change makes us drop them before that happens. BUG=119407 TEST=added, also manual: onkeydown/onkeypress/onkeyup don't fire for the power button anymore but do for all other keys on the chrome os keyboard Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128390

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -5 lines)			Patch
M	ui/aura/root_window.h	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	ui/aura/root_window.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura/root_window_unittest.cc	View	3 chunks	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/9835032/1

8 years, 9 months ago (2012-03-23 00:42:44 UTC) #3

Change committed as 128390

Expand Messages | Collapse Messages