Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 98343005: Pepper: More IDL generator cleanup. (Closed)

Created:
7 years ago by teravest
Modified:
7 years ago
Reviewers:
bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: More IDL generator cleanup. This change makes running the test for idl_c_proto work again, by fixing the test. It also removes an unused "BuiltIn" type list in idl_ast, which was very confusing, and performs some other small cleanup I came across while adding support for dev channel versions. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238711

Patch Set 1 #

Patch Set 2 : Clean up IDLNamespace #

Patch Set 3 : Add IDLNamespace to idl_tests #

Patch Set 4 : Fix for json_schema_compiler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -179 lines) Patch
M ppapi/generators/idl_ast.py View 1 4 chunks +3 lines, -12 lines 0 comments Download
M ppapi/generators/idl_c_proto.py View 2 chunks +8 lines, -14 lines 0 comments Download
M ppapi/generators/idl_log.py View 1 chunk +26 lines, -31 lines 0 comments Download
M ppapi/generators/idl_namespace.py View 1 2 chunks +1 line, -3 lines 0 comments Download
M ppapi/generators/idl_node.py View 12 chunks +37 lines, -46 lines 0 comments Download
M ppapi/generators/idl_parser.py View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/generators/idl_tests.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
D ppapi/generators/test_lex.in View 1 chunk +0 lines, -65 lines 0 comments Download
M tools/json_schema_compiler/idl_schema.py View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
teravest
7 years ago (2013-12-03 19:22:08 UTC) #1
bbudge
Rubberstamp LGTM (I don't know this code very well.)
7 years ago (2013-12-04 01:25:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/98343005/40001
7 years ago (2013-12-04 01:55:42 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests, ...
7 years ago (2013-12-04 02:25:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/98343005/60001
7 years ago (2013-12-04 15:24:35 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-04 16:54:28 UTC) #6
Message was sent while issue was closed.
Change committed as 238711

Powered by Google App Engine
This is Rietveld 408576698