Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 983413005: Autofill - more translated strings in card unmasking prompt (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill - more translated strings in card unmasking prompt BUG=none Committed: https://crrev.com/0d995e6a05626168f312568e163759837685c90f Cr-Commit-Position: refs/heads/master@{#319782}

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
https://codereview.chromium.org/983413005/diff/1/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc File chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc (left): https://codereview.chromium.org/983413005/diff/1/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc#oldcode78 chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:78: if (!error_message.empty()) { this is a bug --- it ...
5 years, 9 months ago (2015-03-09 18:06:56 UTC) #2
newt (away)
lgtm
5 years, 9 months ago (2015-03-09 20:49:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983413005/1
5 years, 9 months ago (2015-03-09 21:30:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/3686) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-09 21:35:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983413005/20001
5 years, 9 months ago (2015-03-09 22:37:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 00:00:27 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 00:01:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d995e6a05626168f312568e163759837685c90f
Cr-Commit-Position: refs/heads/master@{#319782}

Powered by Google App Engine
This is Rietveld 408576698