Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983413004: Eliminate ui/ios (Closed)

Created:
5 years, 9 months ago by stuartmorgan
Modified:
5 years, 9 months ago
Reviewers:
Nico, smut
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate ui/ios Per the explanation in the bug, ui/ios should not have been created in the first place; this code belongs in the ui/gfx subcomponent. BUG=446643 Committed: https://crrev.com/018f5c02de9fc3e41c273b19e8eb60a503b05d57 Cr-Commit-Position: refs/heads/master@{#319720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -440 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ios/build/bots/chromium.fyi/Chromium_iOS_Simulator_(dbg).json View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/build/bots/chromium.mac/iOS_Simulator_(dbg).json View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/build/bots/tryserver.chromium.mac/ios_dbg_simulator_ninja.json View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/ui_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gfx.gyp View 2 chunks +11 lines, -6 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/gfx/ios/NSString+CrStringDrawing.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/ios/NSString+CrStringDrawing.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/ios/NSString+CrStringDrawing_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/ios/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/ios/uikit_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/ios/uikit_util.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/ios/uikit_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/text_utils_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
D ui/ios/NSString+CrStringDrawing.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/ios/NSString+CrStringDrawing.mm View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/ios/NSString+CrStringDrawing_unittest.mm View 1 chunk +0 lines, -151 lines 0 comments Download
D ui/ios/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/ios/ui_ios.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/ios/ui_ios_tests.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/ios/uikit_util.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/ios/uikit_util.mm View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/ios/uikit_util_unittest.mm View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stuartmorgan
5 years, 9 months ago (2015-03-09 17:20:24 UTC) #2
Nico
rs-lgtm
5 years, 9 months ago (2015-03-09 17:29:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983413004/1
5 years, 9 months ago (2015-03-09 17:55:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 20:19:46 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 20:20:29 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/018f5c02de9fc3e41c273b19e8eb60a503b05d57
Cr-Commit-Position: refs/heads/master@{#319720}

Powered by Google App Engine
This is Rietveld 408576698