Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: build/common.gypi

Issue 9834037: apk-based test runner work. Not enabled yet. This CL is a combination of upstreaming, ndk/ant-ifi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more line tweak Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f882f79c005506b008d23672f7ee155c2ba352eb..fe677e6ddea282010d4b97a407b33bf38ac7929f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -780,9 +780,9 @@
'notifications%': 0,
# Builds the gtest targets as a shared_library.
- # TODO(michaelbai): Use the fixed value 'shared_library' once it
- # is fully supported.
- 'gtest_target_type%': '<(gtest_target_type)',
+ # TODO(jrg): when 'gtest_target_type'=='shared_libary' and OS==android,
+ # make all gtest_targets depend on base/base.gyp:native_test_apk.
+ ### 'gtest_target_type': 'shared_libary',
# Uses system APIs for decoding audio and video.
'use_libffmpeg%': '0',
@@ -2347,6 +2347,11 @@
'ldflags': [
'-Wl,-shared,-Bsymbolic',
],
+ # Use of -nostdlib prevents the compiler from bringing
+ # in crtbegin_dynamic.o et al, so we get an undefined
+ # reference to ___dso_handle when building
+ # gtest_target_type==shared_library.
+ 'ldflags!': [ '-nostdlib' ],
}],
],
}],

Powered by Google App Engine
This is Rietveld 408576698