Chromium Code Reviews
Help | Chromium Project | Sign in
(176)

Issue 9834037: apk-based test runner work. Not enabled yet. This CL is a combination of upstreaming, ndk/ant-ifi… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by John Grabowski
Modified:
2 years ago
CC:
chromium-reviews_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org, navabi1, Peter Beverloo, Ted C, Jay Civelli
Visibility:
Public.

Description

apk-based test runner work. Not enabled yet. This CL is a combination of upstreaming, ndk/ant-ification, and other tweaks.


BUG=None
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128679

Patch Set 1 #

Total comments: 33

Patch Set 2 : apply feedback #

Patch Set 3 : one more line tweak #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+487 lines, -12 lines) Lint Patch
M base/base.gyp View 2 chunks +2 lines, -1 line 1 comment ? errors Download
A base/test/android/AndroidManifest.xml View 1 1 chunk +43 lines, -0 lines 4 comments ? errors Download
A base/test/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments ? errors Download
A base/test/android/java/org/chromium/ChromeNativeTestActivity.java View 1 chunk +47 lines, -0 lines 3 comments ? errors Download
A base/test/android/native_test.gyp View 1 1 chunk +40 lines, -0 lines 2 comments ? errors Download
A base/test/android/native_test_apk.xml View 1 1 chunk +37 lines, -0 lines 1 comment ? errors Download
A base/test/android/native_test_launcher.cc View 1 1 chunk +190 lines, -0 lines 0 comments ? errors Download
M build/all_android.gyp View 1 chunk +9 lines, -2 lines 0 comments ? errors Download
M build/android/envsetup.sh View 1 chunk +5 lines, -2 lines 0 comments ? errors Download
M build/android/run_tests.py View 1 chunk +2 lines, -1 line 0 comments ? errors Download
M build/android/single_test_runner.py View 2 chunks +10 lines, -1 line 0 comments ? errors Download
M build/android/test_package.py View 1 chunk +1 line, -0 lines 0 comments ? errors Download
A build/android/test_package_apk.py View 1 2 1 chunk +89 lines, -0 lines 0 comments ? errors Download
M build/common.gypi View 2 chunks +8 lines, -3 lines 0 comments ? errors Download
M build/install-build-deps-android.sh View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ipc/ipc.gyp View 1 chunk +1 line, -1 line 0 comments ? errors Download
Commit:

Messages

Total messages: 10
John Grabowski
jam: for ipc.gyp change (OWNERS) mark: for base.gyp change (OWNERS) bulach: for everything else. Not ...
2 years, 1 month ago #1
bulach
lgtm thanks john! a few nits below, looking forward to have these tests up and ...
2 years, 1 month ago #2
Peter Beverloo
+tedchoc and jcivelli, also some nits. http://chromiumcodereview.appspot.com/9834037/diff/1/base/test/android/AndroidManifest.xml File base/test/android/AndroidManifest.xml (right): http://chromiumcodereview.appspot.com/9834037/diff/1/base/test/android/AndroidManifest.xml#newcode8 base/test/android/AndroidManifest.xml:8: <uses-sdk android:minSdkVersion="8" /> ...
2 years, 1 month ago #3
Mark Mentovai
LGTM. I only reviewed base.gyp and native_test.gyp. http://chromiumcodereview.appspot.com/9834037/diff/1/base/test/android/native_test.gyp File base/test/android/native_test.gyp (right): http://chromiumcodereview.appspot.com/9834037/diff/1/base/test/android/native_test.gyp#newcode7 base/test/android/native_test.gyp:7: ['OS=="android"', { ...
2 years, 1 month ago #4
jam
ipc lgtm
2 years, 1 month ago #5
John Grabowski
Thx for feedback http://chromiumcodereview.appspot.com/9834037/diff/1/base/base.gyp File base/base.gyp (right): http://chromiumcodereview.appspot.com/9834037/diff/1/base/base.gyp#newcode12 base/base.gyp:12: 'test/android/native_test.gyp' On 2012/03/23 10:30:48, bulach wrote: ...
2 years, 1 month ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/9834037/4003
2 years, 1 month ago #7
I haz the power (commit-bot)
Change committed as 128679
2 years, 1 month ago #8
Satish
Some drive-by comments.. http://codereview.chromium.org/9834037/diff/4003/base/base.gyp File base/base.gyp (right): http://codereview.chromium.org/9834037/diff/4003/base/base.gyp#newcode12 base/base.gyp:12: 'test/android/native_test.gyp' should this file have a ...
2 years ago #9
klobag.chromium
2 years ago #10
Drive by review.

http://codereview.chromium.org/9834037/diff/4003/base/test/android/AndroidMan...
File base/test/android/AndroidManifest.xml (right):

http://codereview.chromium.org/9834037/diff/4003/base/test/android/AndroidMan...
base/test/android/AndroidManifest.xml:1: <?xml version="1.0" encoding="utf-8"?>
Need copyright.

http://codereview.chromium.org/9834037/diff/4003/base/test/android/AndroidMan...
base/test/android/AndroidManifest.xml:3: package="org.chromium.native_test"
should this be org.chromium.base.native_test? In Android, package name is
unique. So we can't run base unittest together with net unittest.

http://codereview.chromium.org/9834037/diff/4003/base/test/android/AndroidMan...
base/test/android/AndroidManifest.xml:27: <uses-permission
android:name="android.permission.VIBRATE"/>
Why we need VIBRATE for the base unit test?

Should we review all this permissions?

http://codereview.chromium.org/9834037/diff/4003/base/test/android/java/org/c...
File base/test/android/java/org/chromium/ChromeNativeTestActivity.java (right):

http://codereview.chromium.org/9834037/diff/4003/base/test/android/java/org/c...
base/test/android/java/org/chromium/ChromeNativeTestActivity.java:5: package
org.chromium.native_test;
On 2012/03/27 13:53:24, Satish wrote:
> should this file be under a 'org/chromium/native_test' directory instead of
> 'org/chromium'?

For future proof where we may add resources, we should put it under
base/test/android/java/src/org/chromium/native_test.

http://codereview.chromium.org/9834037/diff/4003/base/test/android/native_tes...
File base/test/android/native_test.gyp (right):

http://codereview.chromium.org/9834037/diff/4003/base/test/android/native_tes...
base/test/android/native_test.gyp:19: 'native_test_launcher.cc'
Should we put native and Java in separate target?

http://codereview.chromium.org/9834037/diff/4003/base/test/android/native_tes...
base/test/android/native_test.gyp:26:
'<(PRODUCT_DIR)/ChromeNativeTests-debug.apk',
Why we have to call "-debug"?

http://codereview.chromium.org/9834037/diff/4003/base/test/android/native_tes...
File base/test/android/native_test_apk.xml (right):

http://codereview.chromium.org/9834037/diff/4003/base/test/android/native_tes...
base/test/android/native_test_apk.xml:1: <?xml version="1.0" encoding="UTF-8"?>
copyright?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6