Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: pkg/compiler/lib/src/dart2js.dart

Issue 983363005: Flag that --dump-info is not supported for dart2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/dart2js.dart
diff --git a/pkg/compiler/lib/src/dart2js.dart b/pkg/compiler/lib/src/dart2js.dart
index 2ea3faa4eafa377924535e6531a9eb11e1c748ff..3350684153c007b1313559a875c25e08a7f75579 100644
--- a/pkg/compiler/lib/src/dart2js.dart
+++ b/pkg/compiler/lib/src/dart2js.dart
@@ -114,6 +114,7 @@ Future<api.CompilationResult> compile(List<String> argv) {
bool stripArgumentSet = false;
bool analyzeOnly = false;
bool analyzeAll = false;
+ bool dumpInfo = false;
bool allowNativeExtensions = false;
bool trustTypeAnnotations = false;
bool trustPrimitives = false;
@@ -206,6 +207,11 @@ Future<api.CompilationResult> compile(List<String> argv) {
passThrough(argument);
}
+ setDumpInfo(String argument) {
+ implyCompilation(argument);
+ dumpInfo = true;
+ }
+
setTrustTypeAnnotations(String argument) {
trustTypeAnnotations = true;
implyCompilation(argument);
@@ -328,7 +334,7 @@ Future<api.CompilationResult> compile(List<String> argv) {
new OptionHandler('--disable-type-inference', implyCompilation),
new OptionHandler('--terse', passThrough),
new OptionHandler('--deferred-map=.+', implyCompilation),
- new OptionHandler('--dump-info', implyCompilation),
+ new OptionHandler('--dump-info', setDumpInfo),
new OptionHandler('--disallow-unsafe-eval',
(_) => hasDisallowUnsafeEval = true),
new OptionHandler('--show-package-warnings', passThrough),
@@ -414,6 +420,10 @@ Future<api.CompilationResult> compile(List<String> argv) {
"combination with the '--analyze-only' option.");
}
}
+ if (dumpInfo && outputLanguage == OUTPUT_LANGUAGE_DART) {
+ helpAndFail("Option '--dump-info' is not supported in "
+ "combination with the '--output-type=dart' option.");
+ }
diagnosticHandler.info('Package root is $packageRoot');
@@ -605,7 +615,9 @@ be removed in a future version:
--dump-info
Generates an out.info.json file with information about the generated code.
You can inspect the generated file with the viewer at:
- https://dart-lang.github.io/dump-info-visualizer/
+ https://dart-lang.github.io/dump-info-visualizer/
+ This feature is currently not supported in combination with the
+ '--output-type=dart' option.
--generate-code-with-compile-time-errors
Generates output even if the program contains compile-time errors. Use the
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698