|
|
DescriptionFix uninit memory access in TranslateManagerRenderViewHostTests.
BUG=464837
Committed: https://crrev.com/63231b5edb0d74f7997924801698dda869899e6c
Cr-Commit-Position: refs/heads/master@{#319614}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 28 (11 generated)
thestig@chromium.org changed reviewers: + hajimehoshi@chromium.org
BTW, I ran TranslateManagerRenderViewHostTest locally under MSAN with this patch. All tests pass.
lgtm, thanks
Sorry but not lgtm. Can you do that on the constructor of LanguageDetectionDetails?
On 2015/03/09 03:32:24, hajimehoshi wrote: > Sorry but not lgtm. > > Can you do that on the constructor of LanguageDetectionDetails? Sure, is is_cld_reliable = false the better default?
On 2015/03/09 03:34:50, Lei Zhang wrote: > On 2015/03/09 03:32:24, hajimehoshi wrote: > > Sorry but not lgtm. > > > > Can you do that on the constructor of LanguageDetectionDetails? > > Sure, is is_cld_reliable = false the better default? Right.
See patch set 2.
lgtm, thanks!
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983283002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983283002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983283002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983283002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/63231b5edb0d74f7997924801698dda869899e6c Cr-Commit-Position: refs/heads/master@{#319614} |