Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 983283002: Fix uninit memory access in TranslateManagerRenderViewHostTests. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix uninit memory access in TranslateManagerRenderViewHostTests. BUG=464837 Committed: https://crrev.com/63231b5edb0d74f7997924801698dda869899e6c Cr-Commit-Position: refs/heads/master@{#319614}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/translate/core/common/language_detection_details.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 28 (11 generated)
Lei Zhang
5 years, 9 months ago (2015-03-07 04:14:49 UTC) #2
Lei Zhang
BTW, I ran TranslateManagerRenderViewHostTest locally under MSAN with this patch. All tests pass.
5 years, 9 months ago (2015-03-07 04:17:56 UTC) #3
hajimehoshi
lgtm, thanks
5 years, 9 months ago (2015-03-09 03:30:32 UTC) #4
hajimehoshi
Sorry but not lgtm. Can you do that on the constructor of LanguageDetectionDetails?
5 years, 9 months ago (2015-03-09 03:32:24 UTC) #5
Lei Zhang
On 2015/03/09 03:32:24, hajimehoshi wrote: > Sorry but not lgtm. > > Can you do ...
5 years, 9 months ago (2015-03-09 03:34:50 UTC) #6
hajimehoshi
On 2015/03/09 03:34:50, Lei Zhang wrote: > On 2015/03/09 03:32:24, hajimehoshi wrote: > > Sorry ...
5 years, 9 months ago (2015-03-09 03:49:15 UTC) #7
Lei Zhang
See patch set 2.
5 years, 9 months ago (2015-03-09 04:31:21 UTC) #8
hajimehoshi
lgtm, thanks!
5 years, 9 months ago (2015-03-09 04:41:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983283002/20001
5 years, 9 months ago (2015-03-09 04:42:55 UTC) #11
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 06:19:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983283002/20001
5 years, 9 months ago (2015-03-09 07:26:05 UTC) #16
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 07:26:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983283002/20001
5 years, 9 months ago (2015-03-09 11:37:20 UTC) #21
commit-bot: I haz the power
Failed to commit the patch.
5 years, 9 months ago (2015-03-09 11:38:38 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983283002/20001
5 years, 9 months ago (2015-03-09 13:07:07 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 13:08:22 UTC) #27
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:09:30 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63231b5edb0d74f7997924801698dda869899e6c
Cr-Commit-Position: refs/heads/master@{#319614}

Powered by Google App Engine
This is Rietveld 408576698