Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 983243003: optimization/fix: dirty the clip-bounds when we mod the clip in savelayer (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

optimization/fix: dirty the clip-bounds when we mod the clip in savelayer Before the fix, we could use a stale cache of the clipbounds in quickReject. Often this could return false negatives, meaning we would try to draw more than we should (it would eventually be really clipped). Occasionally this could also report false positives (if the layer were outside of the normal canvas bounds, e.g. a layer with an offset imagefilter). BUG=skia: NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/9b3aa54bc9605257c701cf465813f5fb1d7ba39e

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix ws nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/core/SkCanvas.cpp View 1 3 chunks +3 lines, -1 line 0 comments Download
M tests/QuickRejectTest.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
reed1
5 years, 9 months ago (2015-03-11 15:19:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983243003/1
5 years, 9 months ago (2015-03-11 15:19:57 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-11 15:19:58 UTC) #5
robertphillips
lgtm + nit https://codereview.chromium.org/983243003/diff/1/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/983243003/diff/1/src/core/SkCanvas.cpp#newcode833 src/core/SkCanvas.cpp:833: bool SkCanvas::clipRectBounds(const SkRect* bounds, SaveFlags flags, ...
5 years, 9 months ago (2015-03-11 15:35:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983243003/20001
5 years, 9 months ago (2015-03-11 15:41:50 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 15:47:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9b3aa54bc9605257c701cf465813f5fb1d7ba39e

Powered by Google App Engine
This is Rietveld 408576698