Revert 238348 "Clean up TestProfileSyncService and related tests"

Revert 238348 "Clean up TestProfileSyncService and related tests"

This CL appeared to be the cause of a link failure on Win dbg: http://goo.gl/PTFpFF

> Clean up TestProfileSyncService and related tests
> 
> This CL refactors many of the tests in profile_sync_service_unittest.cc.
> It continues the refactoring work begun in r233533, r235661, and
> r235854.
> 
> The JsController tests have been deleted.  There is not much point in
> testing the JsController here; it can be more easily tested on its own
> in sync_js_controller_uniittest.cc.  The SyncJsController unit tests
> have been updated so they now cover the few cases that were formerly
> only exercised in the ProfileSyncService unit tests.
> 
> It converts all remaining uncoverted tests from relying on the
> TestProfileSyncService to using a real ProfileSyncService with an
> injected backend.  The injected backend makes it easier to create the
> scenarios we want to test.  We can inject a specially crafted SBH rather
> than fiddling with "synchronous init" and "fail initial download" flags.
> 
> Since the TestProfileSyncService no longer needs to support the wide
> variety of test scenarios required by the tests in
> profile_sync_service_unittest.cc, we can greatly simplify its
> implementation.  Many of its parameters and associated code have been
> removed.
> 
> BUG=140354, 312994
> 
> Review URL: https://codereview.chromium.org/67683005

TBR=rlarocque@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238368

[Patrick Dubroy, 2013-12-03 12:25:20]

Committed patchset #1 manually as r238368.

[rlarocque, 2013-12-03 18:04:12]

I know this sounds crazy, but I'm strongly inclined to blame the buildbot for
that failure.

My patch removes all instances of that symbol.  I'm unable to find the string
"GetBackendForTest" anywhere in the code base once my patch is applied.  

I don't know where the compiler got the idea to look for such a symbol, but it
certainly didn't get it from the code as written.  It must have been a stale
object file from a previous build.

[Patrick Dubroy, 2013-12-03 19:24:25]

Possible...feel free to re-land. I was just operating under the rule of
"revert first, ask questions later" :-)

Pat


On Tue, Dec 3, 2013 at 7:04 PM, <rlarocque@chromium.org> wrote:

> I know this sounds crazy, but I'm strongly inclined to blame the buildbot
> for
> that failure.
>
> My patch removes all instances of that symbol.  I'm unable to find the
> string
> "GetBackendForTest" anywhere in the code base once my patch is applied.
>
> I don't know where the compiler got the idea to look for such a symbol,
> but it
> certainly didn't get it from the code as written.  It must have been a
> stale
> object file from a previous build.
>
> https://codereview.chromium.org/98323003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.