Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983223004: base: Remove non-const refs from the MRUCache implementation. (Closed)

Created:
5 years, 9 months ago by danakj
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove non-const refs from the MRUCache implementation. R=Nico BUG=464816 Committed: https://crrev.com/6b978bf601bbc778040de05a433e2333e461a3fe Cr-Commit-Position: refs/heads/master@{#319693}

Patch Set 1 #

Total comments: 1

Patch Set 2 : mrucache2: const-refs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M base/containers/mru_cache.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/common/webservice_cache.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/common/webservice_cache.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
danakj
5 years, 9 months ago (2015-03-07 00:53:51 UTC) #1
Nico
https://codereview.chromium.org/983223004/diff/1/base/containers/mru_cache.h File base/containers/mru_cache.h (right): https://codereview.chromium.org/983223004/diff/1/base/containers/mru_cache.h#newcode246 base/containers/mru_cache.h:246: void operator()(PayloadType* payload) { delete *payload; } can't you ...
5 years, 9 months ago (2015-03-07 01:06:14 UTC) #2
danakj
On 2015/03/07 01:06:14, Nico wrote: > https://codereview.chromium.org/983223004/diff/1/base/containers/mru_cache.h > File base/containers/mru_cache.h (right): > > https://codereview.chromium.org/983223004/diff/1/base/containers/mru_cache.h#newcode246 > ...
5 years, 9 months ago (2015-03-09 16:17:26 UTC) #3
danakj
PTAL
5 years, 9 months ago (2015-03-09 17:22:48 UTC) #4
Nico
lgtm
5 years, 9 months ago (2015-03-09 17:28:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983223004/20001
5 years, 9 months ago (2015-03-09 17:36:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 18:26:02 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:26:41 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6b978bf601bbc778040de05a433e2333e461a3fe
Cr-Commit-Position: refs/heads/master@{#319693}

Powered by Google App Engine
This is Rietveld 408576698