Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 983213005: Move material Input component into sky/framework (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move material Input component into sky/framework The implementation details are in sky/framework/editing. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e08f333ac33cbe86c94b0df6edd22a39e1c9a7c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -335 lines) Patch
D sky/examples/editor/editable_string.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D sky/examples/editor/editable_text.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D sky/examples/editor/editor_app.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/examples/editor/index.sky View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/examples/editor/input.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D sky/examples/editor/keyboard.dart View 1 chunk +0 lines, -20 lines 0 comments Download
A + sky/examples/input/index.sky View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/examples/input/input_app.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/framework/editing/editable_string.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/editing/editable_text.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/framework/editing/keyboard.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/framework/input.dart View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-10 21:57:20 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-10 22:03:04 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-10 22:03:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e08f333ac33cbe86c94b0df6edd22a39e1c9a7c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698