Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 983213003: ozone: evdev: Fix possibility of stuck mouse buttons (Closed)

Created:
5 years, 9 months ago by spang
Modified:
5 years, 9 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Fix possibility of stuck mouse buttons Same as previous fix, but for mouse buttons. The SYN_DROPPED part is N/A because that is handled by libevdev. BUG=463002 TEST=Tested unplug by unplugging mouse with left button held. Left mouse button gets properly released rather than being stuck. (NB: Could not reproduce without adding a delay to expose the race). Committed: https://crrev.com/ba7886ae1f916481419df25f923307df1e191579 Cr-Commit-Position: refs/heads/master@{#319699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 3 chunks +8 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 3 chunks +32 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 9 months ago (2015-03-07 00:35:08 UTC) #2
kpschoedel
Same LGTM as previous fix, but for mouse buttons.
5 years, 9 months ago (2015-03-07 02:29:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983213003/1
5 years, 9 months ago (2015-03-09 17:49:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 18:40:12 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:41:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba7886ae1f916481419df25f923307df1e191579
Cr-Commit-Position: refs/heads/master@{#319699}

Powered by Google App Engine
This is Rietveld 408576698