Sync the HTMLElement interface with the spec

Sync the HTMLElement interface with the spec

https://html.spec.whatwg.org/#htmlelement

BUG=460722
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191490

[philipj_slow, 2015-03-06 18:51:13]

philipj@opera.com changed reviewers:
+ jl@opera.com

[philipj_slow, 2015-03-06 18:51:14]

PTAL. No real changes.

[Jens Widell, 2015-03-06 19:04:22]

LGTM

https://codereview.chromium.org/983213002/diff/1/Source/core/html/HTMLElement...
File Source/core/html/HTMLElement.idl (right):

https://codereview.chromium.org/983213002/diff/1/Source/core/html/HTMLElement...
Source/core/html/HTMLElement.idl:29: // FIXME: dataset is on HTMLElement
Don't understand. This is HTMLElement. Where is dataset?

https://codereview.chromium.org/983213002/diff/1/Source/core/html/HTMLElement...
Source/core/html/HTMLElement.idl:53: [Reflect, TreatNullAs=NullString,
MeasureAs=PrefixedHTMLElementDropzone] attribute DOMString webkitdropzone;
Should perhaps be nullable instead of TreatNullAs=NullString?

[philipj_slow, 2015-03-07 15:20:24]

https://codereview.chromium.org/983213002/diff/1/Source/core/html/HTMLElement...
File Source/core/html/HTMLElement.idl (right):

https://codereview.chromium.org/983213002/diff/1/Source/core/html/HTMLElement...
Source/core/html/HTMLElement.idl:29: // FIXME: dataset is on HTMLElement
On 2015/03/06 19:04:22, Jens Widell wrote:
> Don't understand. This is HTMLElement. Where is dataset? 

Oops, just copypasta, it's on Element.

https://codereview.chromium.org/983213002/diff/1/Source/core/html/HTMLElement...
Source/core/html/HTMLElement.idl:53: [Reflect, TreatNullAs=NullString,
MeasureAs=PrefixedHTMLElementDropzone] attribute DOMString webkitdropzone;
On 2015/03/06 19:04:22, Jens Widell wrote:
> Should perhaps be nullable instead of TreatNullAs=NullString? 

That actually changes the generated code from v8SetReturnValueString to
v8SetReturnValueStringOrNull, which makes the attribute null instead of "" when
the content attribute it not present. Probably best to leave this alone and do
it right with the unprefixed attribute.

[philipj_slow, 2015-03-07 15:20:34]

dataset is on Element

[philipj_slow, 2015-03-07 15:20:41]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-03-07 15:20:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jl@opera.com
Link to the patchset: https://codereview.chromium.org/983213002/#ps20001 (title:
"dataset is on Element")

[commit-bot: I haz the power, 2015-03-07 15:21:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/983213002/20001

[commit-bot: I haz the power, 2015-03-08 22:34:05]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191490