Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 983183002: Intrinsics in the RUNTIME_FUNCTION_LIST are now available with '_', too. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Intrinsics in the RUNTIME_FUNCTION_LIST are now available with '_', too. Now the three intrinsic lists only differ in their compiler support. Unifying the lists and making the logic what is supported in which compiler local to the compilers themselves is handled in a follow-up CL. BUG=v8:3947 LOG=n Committed: https://crrev.com/e2ce456754368cb11a24cacc2a1d1c5fe6f05e5b Cr-Commit-Position: refs/heads/master@{#27046}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed condition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M src/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 chunks +18 lines, -10 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sven Panne
5 years, 9 months ago (2015-03-06 14:04:34 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/983183002/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/983183002/diff/1/src/hydrogen.cc#newcode9938 src/hydrogen.cc:9938: (this->*generator)(expr); nit: DCHECK(generator != nullptr) or make sure ...
5 years, 9 months ago (2015-03-06 14:13:16 UTC) #3
Sven Panne
https://codereview.chromium.org/983183002/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/983183002/diff/1/src/hydrogen.cc#newcode9938 src/hydrogen.cc:9938: (this->*generator)(expr); On 2015/03/06 14:13:16, Michael Starzinger wrote: > nit: ...
5 years, 9 months ago (2015-03-06 14:33:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983183002/20001
5 years, 9 months ago (2015-03-06 14:35:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 14:58:41 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 14:59:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2ce456754368cb11a24cacc2a1d1c5fe6f05e5b
Cr-Commit-Position: refs/heads/master@{#27046}

Powered by Google App Engine
This is Rietveld 408576698