Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: src/compiler/change-lowering.cc

Issue 983153002: [turbofan] Add an extra frame state for deoptimization before binary op. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tweak Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/change-lowering.cc
diff --git a/src/compiler/change-lowering.cc b/src/compiler/change-lowering.cc
index 0d9aa508ad671196057770dc7e38844cf4487dc6..a5771688f2e778c6f0966608eb4770d4a1c0454d 100644
--- a/src/compiler/change-lowering.cc
+++ b/src/compiler/change-lowering.cc
@@ -229,10 +229,12 @@ Reduction ChangeLowering::ChangeTaggedToFloat64(Node* value, Node* control) {
Diamond d1(graph(), common(), TestNotSmi(object), BranchHint::kFalse);
d1.Chain(control);
+ DCHECK(FLAG_turbo_deoptimization ==
Benedikt Meurer 2015/03/09 05:32:34 DCHECK_EQ?
Jarin 2015/03/09 07:47:11 Done.
+ (OperatorProperties::GetFrameStateInputCount(value->op()) == 1));
Node* number =
- OperatorProperties::HasFrameStateInput(value->op())
+ FLAG_turbo_deoptimization
? graph()->NewNode(value->op(), object, context,
- NodeProperties::GetFrameStateInput(value),
+ NodeProperties::GetFrameStateInput(value, 0),
effect, d1.if_true)
: graph()->NewNode(value->op(), object, context, effect,
d1.if_true);

Powered by Google App Engine
This is Rietveld 408576698