Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 983143003: Support of specify local prebuilt network service file. (Closed)

Created:
5 years, 9 months ago by haltonhuo
Modified:
5 years, 9 months ago
Reviewers:
cjhopman, qsr, blundell
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support of specify local prebuilt network service file. This change is chromium part of https://codereview.chromium.org/921053003/ And out-of-date TODO is removed as well. TEST= BUG=458409 Committed: https://crrev.com/176dd4a94f2fbea1d0962888b3f62bdc21e76cd7 Cr-Commit-Position: refs/heads/master@{#319783}

Patch Set 1 #

Patch Set 2 : Rename var to prebuilt_network_service_location #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M build/module_args/mojo.gni View 1 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
haltonhuo
blundell, as we discussed in https://codereview.chromium.org/921053003/, this CL is uploaded for chromium part. Please review.
5 years, 9 months ago (2015-03-06 15:32:32 UTC) #2
haltonhuo
qsr, as you suggested in https://codereview.chromium.org/921053003/, I renamed the var as prebuilt_network_service_location
5 years, 9 months ago (2015-03-09 12:21:19 UTC) #4
qsr
lgtm
5 years, 9 months ago (2015-03-09 13:10:23 UTC) #5
haltonhuo
On 2015/03/09 13:10:23, qsr wrote: > lgtm Thanks for review. cjhopman, could you give your ...
5 years, 9 months ago (2015-03-09 13:32:15 UTC) #6
cjhopman
lgtm
5 years, 9 months ago (2015-03-09 17:13:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983143003/20001
5 years, 9 months ago (2015-03-09 23:13:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 00:03:58 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 00:04:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/176dd4a94f2fbea1d0962888b3f62bdc21e76cd7
Cr-Commit-Position: refs/heads/master@{#319783}

Powered by Google App Engine
This is Rietveld 408576698