Source/bindings/scripts/v8_types.py - Issue 983123003: Add [TypeChecking=Interface] to XPath interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 983123003: Add [TypeChecking=Interface] to XPath interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: revert test change; no longer needed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index c6b78508e771247cf1e8f1c22f97500f8f87e93a..c14d2de4f3534e84d8beae18b40b1f06e476831e 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -889,6 +889,8 @@ IdlTypeBase.cpp_value_to_v8_value = cpp_value_to_v8_value

def literal_cpp_value(idl_type, idl_literal):

"""Converts an expression that is a valid C++ literal for this type."""

# FIXME: add validation that idl_type and idl_literal are compatible

+ if idl_type.base_type in ('any', 'object') and idl_literal.is_null:

+ return 'ScriptValue()'

literal_value = str(idl_literal)

if idl_type.base_type in CPP_UNSIGNED_TYPES:

return literal_value + 'u'