LayoutTests/fast/xpath/xpath-empty-string.html - Issue 983123003: Add [TypeChecking=Interface] to XPath interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/xpath/xpath-empty-string.html

Issue 983123003: Add [TypeChecking=Interface] to XPath interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix CG for any/object argument with default value Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/xpath/xpath-empty-string.html

diff --git a/LayoutTests/fast/xpath/xpath-empty-string.html b/LayoutTests/fast/xpath/xpath-empty-string.html

index b122b150ab6f9575e032abbb813d9f7a0ef90b51..1e0cf3b21c1e75964f817c96f3338ba73f0b7fe5 100644

--- a/LayoutTests/fast/xpath/xpath-empty-string.html

+++ b/LayoutTests/fast/xpath/xpath-empty-string.html

@@ -4,14 +4,13 @@

function runTests() {

if (window.testRunner)

testRunner.dumpAsText();

- document.evaluate("//a[@id='']",document)

+ document.evaluate("//a[@id='']", document, null, XPathResult.ANY_TYPE, null);

philipj_slow 2015/03/09 08:17:30 This test change shouldn't be needed any longer.

Jens Widell 2015/03/09 11:05:10 True. I've reverted it.

}

</script>

</head>

This tests that parsing an XPath expression that contains an empty string literal doesn't segfault.<br>

SUCCESS: Didn't crash!

</body>

-</html>

+</html>