Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: shell/native_runner_unittest.cc

Issue 983113002: ApplicationManager: Use callback to get notified on application shutdown. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Rebase after parameters fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/context.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/native_runner_unittest.cc
diff --git a/shell/native_runner_unittest.cc b/shell/native_runner_unittest.cc
index 7faee0496fba40a0c50c3ffc3d0c173d877cddcf..5676405411de496672d91cae23f5f3ccba1a2e17 100644
--- a/shell/native_runner_unittest.cc
+++ b/shell/native_runner_unittest.cc
@@ -78,8 +78,6 @@ class NativeApplicationLoaderTest : public testing::Test,
private:
// ApplicationManager::Delegate
- void OnApplicationError(const GURL& url) override {}
-
GURL ResolveURL(const GURL& url) override { return url; }
GURL ResolveMappings(const GURL& url) override { return url; }
@@ -92,8 +90,8 @@ TEST_F(NativeApplicationLoaderTest, DoesNotExist) {
GURL url(FilePathToFileURL(temp_dir.path().Append(nonexistent_file)));
InterfaceRequest<ServiceProvider> services;
ServiceProviderPtr service_provider;
- application_manager_.ConnectToApplication(url, GURL(), services.Pass(),
- service_provider.Pass());
+ application_manager_.ConnectToApplication(
+ url, GURL(), services.Pass(), service_provider.Pass(), base::Closure());
EXPECT_FALSE(state_.runner_was_created);
EXPECT_FALSE(state_.runner_was_started);
EXPECT_FALSE(state_.runner_was_destroyed);
« no previous file with comments | « shell/context.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698