Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: shell/application_manager/shell_impl.h

Issue 983113002: ApplicationManager: Use callback to get notified on application shutdown. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Rebase after parameters fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/application_manager/application_manager_unittest.cc ('k') | shell/application_manager/shell_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/application_manager/shell_impl.h
diff --git a/shell/application_manager/shell_impl.h b/shell/application_manager/shell_impl.h
index f3fcefe1d8fa36cf3a67d6c02151363fe3b23812..4dbef20de005f5ae36f87288476ea23afd6a6619 100644
--- a/shell/application_manager/shell_impl.h
+++ b/shell/application_manager/shell_impl.h
@@ -5,6 +5,7 @@
#ifndef SHELL_APPLICATION_MANAGER_SHELL_IMPL_H_
#define SHELL_APPLICATION_MANAGER_SHELL_IMPL_H_
+#include "base/callback.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "mojo/public/cpp/bindings/error_handler.h"
#include "mojo/public/interfaces/application/application.mojom.h"
@@ -21,9 +22,8 @@ class ShellImpl : public Shell, public ErrorHandler {
public:
ShellImpl(ApplicationPtr application,
ApplicationManager* manager,
- // The original URL that was first requested, before any resolution.
- const GURL& original_url,
- const Identity& resolved_identity);
+ const Identity& resolved_identity,
+ const base::Closure& on_application_end);
~ShellImpl() override;
@@ -36,7 +36,7 @@ class ShellImpl : public Shell, public ErrorHandler {
Application* application() { return application_.get(); }
const Identity& identity() const { return identity_; }
- const GURL& requested_url() const { return requested_url_; }
+ base::Closure on_application_end() const { return on_application_end_; }
private:
// Shell implementation:
@@ -48,8 +48,8 @@ class ShellImpl : public Shell, public ErrorHandler {
void OnConnectionError() override;
ApplicationManager* const manager_;
- const GURL requested_url_;
const Identity identity_;
+ base::Closure on_application_end_;
ApplicationPtr application_;
Binding<Shell> binding_;
« no previous file with comments | « shell/application_manager/application_manager_unittest.cc ('k') | shell/application_manager/shell_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698